commit 1fef57f248139c712b4f92e4654f2cb7ec50b11a
parent 6016afc424625addff93094ef57c63f4eeebbb17
Author: Kévin Le Gouguec <kevin.legouguec@gmail.com>
Date: Fri, 30 Aug 2019 11:33:49 +0200
Take notes on David Lloyd's code review tips
Diffstat:
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/README.md b/README.md
@@ -1,5 +1,5 @@
# Peniblec's Memory Leaks
-## still reachable: 9552 words in 22 pages
+## still reachable: 9633 words in 22 pages
Hi! I am a software engineer interested in [a bunch of things].
diff --git a/reviews/blog-roll.md b/reviews/blog-roll.md
@@ -121,3 +121,21 @@ enough hindsight to find where that thought process fell short.
[Bartosz Ciechanowski]: https://ciechanow.ski/
[Alpha Compositing]: https://ciechanow.ski/alpha-compositing/
+
+# [Red Hat Developer]
+
+[10 tips for reviewing code you don't like]
+: The article could basically be included as-is in a [nonviolent
+ communication] textbook and renamed "application to code reviews".
+
+ AFAICT the underlying principle to all these tips is: scrub
+ judgmental statements out of your responses, and state your
+ concerns openly. Nobody should expect you to hold all the
+ answers; express your uncertainty, and let the submitter do the
+ work of convincing you (e.g. checking for performance regressions,
+ splitting patch series).
+
+
+[Red Hat Developer]: https://developers.redhat.com/blog/
+[10 tips for reviewing code you don't like]: https://developers.redhat.com/blog/2019/07/08/10-tips-for-reviewing-code-you-dont-like/
+[nonviolent communication]: https://en.wikipedia.org/wiki/Nonviolent_Communication
diff --git a/reviews/stack.org b/reviews/stack.org
@@ -1,9 +1,6 @@
A list of things I plan on reading someday, or have read but have not
yet commented on.
-* [[https://developers.redhat.com/blog/2019/07/08/10-tips-for-reviewing-code-you-dont-like/][10 tips for reviewing code you don’t like]]
-Somewhat topical with the [[https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00246.html][recent clash on emacs-devel]].
-
* [[https://blog.regehr.org/archives/1676][It’s Time for a Modern Synthesis Kernel]]
* Rust stuff
