diff options
| author | Kévin Le Gouguec <kevin.legouguec@gmail.com> | 2019-08-30 11:33:49 +0200 |
|---|---|---|
| committer | Kévin Le Gouguec <kevin.legouguec@gmail.com> | 2019-08-30 11:34:35 +0200 |
| commit | 1fef57f248139c712b4f92e4654f2cb7ec50b11a (patch) | |
| tree | b7e8615655775625797a3f3a7552c2d3d43d8fdc /reviews/blog-roll.md | |
| parent | 6016afc424625addff93094ef57c63f4eeebbb17 (diff) | |
| download | memory-leaks-1fef57f248139c712b4f92e4654f2cb7ec50b11a.tar.xz | |
Take notes on David Lloyd's code review tips
Diffstat (limited to 'reviews/blog-roll.md')
| -rw-r--r-- | reviews/blog-roll.md | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/reviews/blog-roll.md b/reviews/blog-roll.md index e9113fc..796d214 100644 --- a/reviews/blog-roll.md +++ b/reviews/blog-roll.md @@ -121,3 +121,21 @@ enough hindsight to find where that thought process fell short. [Bartosz Ciechanowski]: https://ciechanow.ski/ [Alpha Compositing]: https://ciechanow.ski/alpha-compositing/ + +# [Red Hat Developer] + +[10 tips for reviewing code you don't like] +: The article could basically be included as-is in a [nonviolent + communication] textbook and renamed "application to code reviews". + + AFAICT the underlying principle to all these tips is: scrub + judgmental statements out of your responses, and state your + concerns openly. Nobody should expect you to hold all the + answers; express your uncertainty, and let the submitter do the + work of convincing you (e.g. checking for performance regressions, + splitting patch series). + + +[Red Hat Developer]: https://developers.redhat.com/blog/ +[10 tips for reviewing code you don't like]: https://developers.redhat.com/blog/2019/07/08/10-tips-for-reviewing-code-you-dont-like/ +[nonviolent communication]: https://en.wikipedia.org/wiki/Nonviolent_Communication |