From ecf10606d4fa423571f6802a30dddf57a10eab1c Mon Sep 17 00:00:00 2001 From: Kévin Le Gouguec Date: Sat, 29 Oct 2022 13:27:03 +0200 Subject: Mark ada-mode itch as scratched The way upstream handled that one was somewhat confusing. The timeline I remember: 1. November 2021: bug opened. 2. May 2022: bug closed, with no acknowledgment of patches whatsoever: > Date: Sat, 28 May 2022 04:15:57 -0700 > Closed by ada-mode version 7.2.1, uniquify-files version 1.0.4. _AFAIR_ (and this is where I doubt my own sanity), those new versions were never pushed anywhere public? The commit dates that eventually made it to the GNU ELPA repo show that the patches were applied on May 28, so you'd think I should have been able to see them, but I distinctly remember seeing the bug-closed notification and expectantly looking at GNU ELPA (via list-packages, the website, and finally fetching from the git repo) and seeing *nothing*. 3. July 2022: the new package versions mentioned in the bug-closed notification are finally published on GNU ELPA; elpa.git is updated; I check the log and don't see my patches; I check the sources and do end up finding my changes. OT1H I certainly won't presume to tell upstream how to handle user contributions; OTOH the combination of (1) the curt closing message that neither ACK'ed nor NACK'ed the patches (2) the months-long radio silence between closing and releasing (3) the loss of attribution, all make for a rather austere contribution process. --- itches/emacs/tracker.org | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'itches') diff --git a/itches/emacs/tracker.org b/itches/emacs/tracker.org index d594809..ab2f603 100644 --- a/itches/emacs/tracker.org +++ b/itches/emacs/tracker.org @@ -655,13 +655,28 @@ split anyway"; the problem occurs without wrap-prefixes. - [ ] current buffer (run-python) * ELPA ** ada-mode -*** TODO Preserve default value of ~project-read-file-name-function~ +*** DONE [[bug:52167]] Preserve default value of ~project-read-file-name-function~ +:PROPERTIES: +:Role: author +:PatchApplied: t +:END: ada-mode pulls in uniquify-files, which unconditionally changes the default value of ~project-read-file-name-function~. - In uniquify-files: stop doing that; advertise this setting in the package commentary. - In ada-mode: let-bind this variable in ~ada-find-file~. + +Patches applied, though the maintainer did not preserve authorship nor +rationales from the commit messages. For my own sanity: + +- [[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52167;msg=5;att=1;filename=0001-Preserve-default-value-of-project-read-file-name-fun.patch][uniquify-files patch]] applied [[https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?h=externals/uniquify-files&id=1d76b4f0e283afaff2be053d85f8726ffc3abd6e][here]]; +- [[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52167;msg=5;att=2;filename=0001-Explicitly-bind-project-read-file-name-function.patch][ada-mode patch 1]]: + - (ada-mode.el) applied [[https://git.savannah.nongnu.org/cgit/ada-mode.git/commit/?h=org.emacs.ada-mode&id=cd3bdbf6993d5f070795399c8f5ea538291c1d73][here]] (with further comment tweak), squashed + with [[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52167;msg=5;att=4;filename=0003-ada-mode.el-ada-find-file-Support-future-Emacs-versi.patch][patch 3]]; + - (NEWS) applied [[https://git.savannah.nongnu.org/cgit/ada-mode.git/commit/?h=org.emacs.ada-mode&id=e5bc6c3c][there]]; +- [[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52167;msg=5;att=3;filename=0002-ada-mode.el-ada-mode-menu-Prefer-ada-find-file.patch][ada-mode patch 2]]: not applied; +- [[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52167;msg=5;att=4;filename=0003-ada-mode.el-ada-find-file-Support-future-Emacs-versi.patch][ada-mode patch 3]]: applied [[https://git.savannah.nongnu.org/cgit/ada-mode.git/commit/?h=org.emacs.ada-mode&id=cd3bdbf6993d5f070795399c8f5ea538291c1d73][here]], squashed with [[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52167;msg=5;att=2;filename=0001-Explicitly-bind-project-read-file-name-function.patch][patch 1]]. ** adaptive-wrap *** DONE [[bug:41810]] Fontify wrap-prefix :PROPERTIES: -- cgit v1.2.3