From 78ac6d448a77d6047f82c136633b251ddb820fca Mon Sep 17 00:00:00 2001 From: Gaetan Leplus Date: Fri, 5 Jul 2019 09:49:36 +0200 Subject: Ajout du changelog pour add_vhdl --- CHANGELOG.txt | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 115 insertions(+), 1 deletion(-) (limited to 'CHANGELOG.txt') diff --git a/CHANGELOG.txt b/CHANGELOG.txt index d836ba6..7d7413f 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -1,7 +1,121 @@ v1.1 ==== -TODO +ref +--- + +### Fixes + +These modifications change the algorithm's output. + +- Change alpha coefficients in tweakey schedule to ensure lane 0 is updated between each round: + - lane 0: Id => M + - lane 1: M => M^2 + - lane 2: M^2 => M^3 + - lane 3: M^3 => M^4 + - lane 4: M_R (unchanged) + - lane 5: M_R^2 (unchanged) + - lane 6: M_R^3 (unchanged) + (multiplications.h, tweakey.c) + +### Cleanups + +These modifications are structural and/or stylistic and do not change the algorithm's ouptut. + +- Introduce helper function copy_block_index() to make tweak-building functions more legible. + (lilliput-ae-utils.h, lilliput-i.c, lilliput-ii.c) + +- Initialize ΘCB3 tweak with nonce instead of copying the latter into the latter repeatedly. + (lilliput-i.c) + +- Re-write _nonlinear_layer() and _linear_layer() functions to better resemble the specification. + (cipher.c) + +- Extract tweakey multiplications into their own header file, so that other implementations can make more targeted changes. + (constants.h, multiplications.h, tweakey.c) + +add_threshold +------------- + +### Fixes + +See reference implementation. + +### Cleanups + +See reference implementation. Further cleanups: + +- Use size_t to iterate on arrays in lilliput_tbc_encrypt() and lilliput_tbc_decrypt(). + (cipher.c) + +- Add constant macros KEY_LANES_NB and TWEAK_LANES_NB to make tweakey schedule code more legible. + (tweakey.c) + +add_tweakeyloop +--------------- + +See reference implementation. + +add_python +---------- + +### Fixes + +See reference implementation. + +### Cleanups + +- Re-write tweakey multiplications to better resemble the specification. + (multiplications.py) + +add_vhdl +-------- + +### Reorganization + +- A more synthetical organisation was chosen. Indeed, Lilliput-II only need encryption and Lilliput-I need encryption and decryption, so LilliputTBCencrypt is always used for lilliput-I and LilliputTBCencryptdecrypt for Lilliput-II. And LilliputTBCdecrypt is no longer described because no version uses it. + +### Fixes + +- For all vhdl versions we change coefficients in tweakey schedule to ensure lane 0 is updated between each encryption round: + - lane 0: Id => M + - lane 1: M => M^2 + - lane 2: M^2 => M^3 + - lane 3: M^3 => M^4 + - lane 4: M_R (unchanged) + - lane 5: M_R^2 (unchanged) + - lane 6: M_R^3 (unchanged) + (multiplication.vhd) + +- For Lilliput-I we change coefficients in tweakey schedule to ensure lane 0 is updated between each decryption round: + - lane 0: Id => inv(M) + - lane 1: inv(M) => inv(M)^2 + - lane 2: inv(M)^2 => inv(M)^3 + - lane 3: inv(M)^3 => inv(M)^4 + - lane 4: M_R (unchanged) + - lane 5: M_R^2 (unchanged) + - lane 6: M_R^3 (unchanged) + (inv_multiplication.vhd) + + + ### Cleanups + + - Merge Sbox in one file. + (sbox.vhd, inner_sbox_a.vhd, inner_sbox_b, vhd,inner_sbox_c.vhd) + + - Create registers in file roundexe_lilliput.vhd. + (state_key_register.vhd, state_register.vhd, roundexe_lilliput) + + - Reduction of the number of signals. + (chiffrement.vhd) + + ### Optimizations + + - Pipeline RoundTweakey extraction and round function. + (roundexe_lilliput.vhd, machine_etat_chiffrement.vhd) + + - Isolate input and output from critical path. + (roundexe_lilliput.vhd, machine_etat_chiffrement.vhd) v1.0 ==== -- cgit v1.2.3 From 61de782f890a8fee384ac5d0480b52de219e91ab Mon Sep 17 00:00:00 2001 From: Gaetan Leplus Date: Fri, 5 Jul 2019 10:31:59 +0200 Subject: Simplification du format du changelog --- CHANGELOG.txt | 79 ++++++++++++++++++++++++----------------------------------- 1 file changed, 32 insertions(+), 47 deletions(-) (limited to 'CHANGELOG.txt') diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 7d7413f..78e8e63 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -1,13 +1,33 @@ +This document summarizes the modifications brought by each version. Some modifications are tagged as follows: + +- [spec] when the modification is brought by a new revision of the specification, +- [break] when the modification changes the implementation's output. + +A modification that has no tag corresponds to stylistic and/or structural changes that have no impact on test vectors. + + v1.1 ==== ref --- -### Fixes +- Introduce helper function copy_block_index() to make tweak-building functions more legible. + (lilliput-ae-utils.h, lilliput-i.c, lilliput-ii.c) + +- Initialize ΘCB3 tweak with nonce instead of copying the latter into the latter repeatedly. + (lilliput-i.c) + +- Re-write _nonlinear_layer() and _linear_layer() functions to better resemble the specification. + (cipher.c) + +- Extract tweakey multiplications into their own header file, so that other implementations can make more targeted changes. + (constants.h, multiplications.h, tweakey.c) -These modifications change the algorithm's output. +- Use size_t to iterate on arrays in lilliput_tbc_encrypt() and lilliput_tbc_decrypt(). + (cipher.c) +[spec][break] - Change alpha coefficients in tweakey schedule to ensure lane 0 is updated between each round: - lane 0: Id => M - lane 1: M => M^2 @@ -18,35 +38,21 @@ These modifications change the algorithm's output. - lane 6: M_R^3 (unchanged) (multiplications.h, tweakey.c) -### Cleanups +add_felicsref +------------- -These modifications are structural and/or stylistic and do not change the algorithm's ouptut. +See reference implementation. Further changes: -- Introduce helper function copy_block_index() to make tweak-building functions more legible. - (lilliput-ae-utils.h, lilliput-i.c, lilliput-ii.c) - -- Initialize ΘCB3 tweak with nonce instead of copying the latter into the latter repeatedly. - (lilliput-i.c) +- Introduce helper function _multiply() to reduce code duplication. + (tweakey.c) -- Re-write _nonlinear_layer() and _linear_layer() functions to better resemble the specification. +- Compute round-tweakeys on the fly to save on RAM, instead of storing all pre-computed round-tweakeys. (cipher.c) -- Extract tweakey multiplications into their own header file, so that other implementations can make more targeted changes. - (constants.h, multiplications.h, tweakey.c) - add_threshold ------------- -### Fixes - -See reference implementation. - -### Cleanups - -See reference implementation. Further cleanups: - -- Use size_t to iterate on arrays in lilliput_tbc_encrypt() and lilliput_tbc_decrypt(). - (cipher.c) +See reference implementation. Further changes: - Add constant macros KEY_LANES_NB and TWEAK_LANES_NB to make tweakey schedule code more legible. (tweakey.c) @@ -59,11 +65,7 @@ See reference implementation. add_python ---------- -### Fixes - -See reference implementation. - -### Cleanups +See [spec] and [break] changes in reference implementation. Further changes: - Re-write tweakey multiplications to better resemble the specification. (multiplications.py) @@ -71,22 +73,10 @@ See reference implementation. add_vhdl -------- -### Reorganization +See [spec] and [break] changes in reference implementation. Further changes: - A more synthetical organisation was chosen. Indeed, Lilliput-II only need encryption and Lilliput-I need encryption and decryption, so LilliputTBCencrypt is always used for lilliput-I and LilliputTBCencryptdecrypt for Lilliput-II. And LilliputTBCdecrypt is no longer described because no version uses it. -### Fixes - -- For all vhdl versions we change coefficients in tweakey schedule to ensure lane 0 is updated between each encryption round: - - lane 0: Id => M - - lane 1: M => M^2 - - lane 2: M^2 => M^3 - - lane 3: M^3 => M^4 - - lane 4: M_R (unchanged) - - lane 5: M_R^2 (unchanged) - - lane 6: M_R^3 (unchanged) - (multiplication.vhd) - - For Lilliput-I we change coefficients in tweakey schedule to ensure lane 0 is updated between each decryption round: - lane 0: Id => inv(M) - lane 1: inv(M) => inv(M)^2 @@ -97,9 +87,6 @@ add_vhdl - lane 6: M_R^3 (unchanged) (inv_multiplication.vhd) - - ### Cleanups - - Merge Sbox in one file. (sbox.vhd, inner_sbox_a.vhd, inner_sbox_b, vhd,inner_sbox_c.vhd) @@ -108,9 +95,7 @@ add_vhdl - Reduction of the number of signals. (chiffrement.vhd) - - ### Optimizations - + - Pipeline RoundTweakey extraction and round function. (roundexe_lilliput.vhd, machine_etat_chiffrement.vhd) -- cgit v1.2.3 From 999b462bb9926d655c753263679227a8eac34fe8 Mon Sep 17 00:00:00 2001 From: Gaetan Leplus Date: Tue, 9 Jul 2019 15:05:09 +0200 Subject: Ajout du testbench auto-testant dans le changelog --- CHANGELOG.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'CHANGELOG.txt') diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 59c03db..a88bb1d 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -114,7 +114,10 @@ See [spec] and [break] changes in reference implementation. Further changes: - Reduction of the number of signals. (chiffrement.vhd) - + + - Add self-checking testbench. + (top_tb.vhd) + - Pipeline RoundTweakey extraction and round function. (roundexe_lilliput.vhd, machine_etat_chiffrement.vhd) -- cgit v1.2.3 From 3bb2d4e95f9bc5b419444b8f49046b516d9f1034 Mon Sep 17 00:00:00 2001 From: Kévin Le Gouguec Date: Tue, 9 Jul 2019 17:32:37 +0200 Subject: Ajustements rédactionnels MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.txt | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'CHANGELOG.txt') diff --git a/CHANGELOG.txt b/CHANGELOG.txt index a88bb1d..8ba361a 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -94,34 +94,34 @@ add_vhdl See [spec] and [break] changes in reference implementation. Further changes: -- A more synthetical organisation was chosen. Indeed, Lilliput-II only need encryption and Lilliput-I need encryption and decryption, so LilliputTBCencrypt is always used for lilliput-I and LilliputTBCencryptdecrypt for Lilliput-II. And LilliputTBCdecrypt is no longer described because no version uses it. +- A simpler file organization was chosen. Lilliput-II only needs encryption, while Lilliput-I needs encryption and decryption, so LilliputTBCencrypt is always used for Lilliput-I and LilliputTBCencryptdecrypt for Lilliput-II. LilliputTBCdecrypt is no longer described because no version uses it. -- For Lilliput-I we change coefficients in tweakey schedule to ensure lane 0 is updated between each decryption round: +- For Lilliput-I, the inverted multiplications have been updated to match changes to the encryption process: - lane 0: Id => inv(M) - lane 1: inv(M) => inv(M)^2 - lane 2: inv(M)^2 => inv(M)^3 - lane 3: inv(M)^3 => inv(M)^4 - - lane 4: M_R (unchanged) - - lane 5: M_R^2 (unchanged) - - lane 6: M_R^3 (unchanged) + - lane 4: M_R (unchanged) + - lane 5: M_R^2 (unchanged) + - lane 6: M_R^3 (unchanged) (inv_multiplication.vhd) - - Merge Sbox in one file. +- Merge Sbox in one file. (sbox.vhd, inner_sbox_a.vhd, inner_sbox_b, vhd,inner_sbox_c.vhd) - - Create registers in file roundexe_lilliput.vhd. +- Create registers in file roundexe_lilliput.vhd. (state_key_register.vhd, state_register.vhd, roundexe_lilliput) - - Reduction of the number of signals. +- Reduction of the number of signals. (chiffrement.vhd) - - Add self-checking testbench. +- Add self-checking testbench. (top_tb.vhd) - - Pipeline RoundTweakey extraction and round function. +- Pipeline RoundTweakey extraction and round function. (roundexe_lilliput.vhd, machine_etat_chiffrement.vhd) - - Isolate input and output from critical path. +- Isolate input and output from critical path. (roundexe_lilliput.vhd, machine_etat_chiffrement.vhd) -- cgit v1.2.3 From 71c27277df9fa7af077947f262f4b3f248c3dea8 Mon Sep 17 00:00:00 2001 From: Kévin Le Gouguec Date: Wed, 10 Jul 2019 15:22:28 +0200 Subject: Quelques reformulations dans le changelog VHDL --- CHANGELOG.txt | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'CHANGELOG.txt') diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 8ba361a..25e80ca 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -89,21 +89,23 @@ See [spec] and [break] changes in reference implementation. Further changes: - Re-write tweakey multiplications to better resemble the specification. (multiplications.py) -add_vhdl --------- +add_vhdltbc +----------- See [spec] and [break] changes in reference implementation. Further changes: -- A simpler file organization was chosen. Lilliput-II only needs encryption, while Lilliput-I needs encryption and decryption, so LilliputTBCencrypt is always used for Lilliput-I and LilliputTBCencryptdecrypt for Lilliput-II. LilliputTBCdecrypt is no longer described because no version uses it. +- Each algorithm variant now contains a single VHDL implementation, add_vhdltbc: + - for Lilliput-I variants, add_vhdltbc corresponds to the former add_vhdltbcencryptdecrypt, + - Lilliput-II variants do not need the decryption part of Lilliput-TBC, therefore add_vhdltbc corresponds to the former add_vdhltbcencrypt. - For Lilliput-I, the inverted multiplications have been updated to match changes to the encryption process: - lane 0: Id => inv(M) - lane 1: inv(M) => inv(M)^2 - lane 2: inv(M)^2 => inv(M)^3 - lane 3: inv(M)^3 => inv(M)^4 - - lane 4: M_R (unchanged) - - lane 5: M_R^2 (unchanged) - - lane 6: M_R^3 (unchanged) + - lane 4: inv(M_R) (unchanged) + - lane 5: inv(M_R)^2 (unchanged) + - lane 6: inv(M_R)^3 (unchanged) (inv_multiplication.vhd) - Merge Sbox in one file. -- cgit v1.2.3